Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

osowski
Copy link
Contributor

@osowski osowski commented Jul 11, 2022

Signed-off-by: Rick Osowski [email protected]

Description

As part of previous changes for multiple Data and Server Pods per Worker Node, Pod FQDNs became longer and certain cases were causing cluster deployment to break post-deployment or fail completely. As such, a previous limit on namespace length was implemented to limit the exposure to these scenarios. Additional work has been done to support longer FQDNs throughout CORTX Core components, so this maximum namespace length limit can be increased.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds new functionality)
  • Breaking change (bug fix or new feature that breaks existing functionality)
  • Third-party dependency update
  • Documentation additions or improvements
  • Code quality improvements to existing code or test additions/updates

Applicable issues

  • This change fixes an issue: #CORTX-33598
  • This change is related to an issue: #

How was this tested?

Locally through many deploy/destroy loops with namespaces of length 8, 10, 15, 20, 25+ characters.

Additional information

Checklist

  • The change is tested and works locally.
  • New or changed settings in the solution YAML are documented clearly in the README.md file.
  • All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change requires newer CORTX or third party image versions:

  • The image fields in solution.example.yaml have been updated to use the required versions.
  • The appVersion field of the Helm chart has been updated to use the new CORTX version.

If this change addresses a CORTX Jira issue:

  • The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)

View rendered README.md

@osowski osowski added documentation Improvements or additions to documentation enhancement New feature or request k8s labels Jul 11, 2022
@osowski osowski requested a review from a team as a code owner July 11, 2022 18:54
@cla-bot cla-bot bot added the cla-signed label Jul 11, 2022
Copy link
Contributor

@keithpine keithpine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know what the remaining limitations are which won't allow a maximum namespace length? Will that be addressed eventually?

We don't account for this limitation in the Chart itself, e.g. a manual Chart deployment could still fail.

@osowski
Copy link
Contributor Author

osowski commented Jul 11, 2022

At the moment, I believe it is the inclusion of the FQDN sub-domain as Labels in the Pod specs for the StatefulSets. We will need to do more investigation on if these are required into the future and/or if the prior HA functionality will be carried through as-is into CC. For now, we can increase this limitation to allow for more robust deployments and circle back to ensure we are driving the need to remove the limitation altogether.

A manual Chart deployment can definitely still fail, but the feedback is much more direct to the Helm user than the bash deploy script user and is more easily rectified.

Copy link
Contributor

@walterlopatka walterlopatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@osowski osowski merged commit e7d5e60 into integration Jul 12, 2022
@osowski osowski deleted the CORTX-33598_increase_max_ns_length branch August 31, 2022 20:35
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed documentation Improvements or additions to documentation enhancement New feature or request k8s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants