Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

keithpine
Copy link
Contributor

@keithpine keithpine commented Jul 8, 2022

Description

Refactor the Chart values for the (Motr) client component.

  • Remove redundant "cortx" prefix
  • Use camelcase to match Helm conventions
  • Convert image into an object. Tag is undefined and will default to the Chart AppVersion value.
  • Default to the real CORTX client image, instead of centos.
  • Allow imagePullPolicy to be configurable

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds new functionality)
  • Breaking change (bug fix or new feature that breaks existing functionality)
  • Third-party dependency update
  • Documentation additions or improvements
  • Code quality improvements to existing code or test additions/updates

Applicable issues

  • This change fixes an issue: CORTX-32157
  • This change is related to an issue: #

How was this tested?

Deployed cluster, with and without Client enabled. Ran m0 client in container.

Ran helm template and saw default values, like the image, being correctly configured.

Checklist

  • The change is tested and works locally.
  • New or changed settings in the solution YAML are documented clearly in the README.md file.
  • All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change requires newer CORTX or third party image versions:

  • The image fields in solution.example.yaml have been updated to use the required versions.
  • The appVersion field of the Helm chart has been updated to use the new CORTX version.

If this change addresses a CORTX Jira issue:

  • The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)

@cla-bot cla-bot bot added the cla-signed label Jul 8, 2022
@keithpine keithpine marked this pull request as ready for review July 8, 2022 15:39
@keithpine keithpine requested a review from a team as a code owner July 8, 2022 15:39
Copy link
Contributor

@osowski osowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keithpine keithpine merged commit c9fa084 into Seagate:integration Jul 11, 2022
@keithpine keithpine deleted the CORTX-32157_refactor-client branch July 11, 2022 17:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants