This repository was archived by the owner on Feb 8, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 47
CORTX-30147: misc Chart-related cleanup #290
Merged
keithpine
merged 14 commits into
Seagate:integration
from
keithpine:CORTX-30147_endpoint-cleanup
Jun 22, 2022
Merged
CORTX-30147: misc Chart-related cleanup #290
keithpine
merged 14 commits into
Seagate:integration
from
keithpine:CORTX-30147_endpoint-cleanup
Jun 22, 2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove generation of Server endpoints from deploy script. This is done in the Helm templates now. - Update port configurations to match the upstream sample file - Simplify local block storage class naming Signed-off-by: Keith Pine <[email protected]>
osowski
reviewed
Jun 21, 2022
osowski
reviewed
Jun 21, 2022
Signed-off-by: Keith Pine <[email protected]>
Signed-off-by: Keith Pine <[email protected]>
Signed-off-by: Keith Pine <[email protected]>
Signed-off-by: Keith Pine <[email protected]>
Signed-off-by: Keith Pine <[email protected]>
Signed-off-by: Keith Pine <[email protected]>
Signed-off-by: Keith Pine <[email protected]>
Signed-off-by: Keith Pine <[email protected]>
Signed-off-by: Keith Pine <[email protected]>
Signed-off-by: Keith Pine <[email protected]>
Signed-off-by: Keith Pine <[email protected]>
osowski
approved these changes
Jun 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Various Helm Chart improvements.
Type of change
Applicable issues
How was this tested?
Deploy/destroy cluster, run util scripts, S3 I/O, CSM API requests.
Checklist
If this change requires newer CORTX or third party image versions:
image
fields in solution.example.yaml have been updated to use the required versions.appVersion
field of the Helm chart has been updated to use the new CORTX version.If this change addresses a CORTX Jira issue:
CORTX-XXXXX:
)View rendered charts/cortx/README.md