Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

keithpine
Copy link
Contributor

@keithpine keithpine commented Jun 20, 2022

Description

Various Helm Chart improvements.

  • Remove generation of Server endpoints from deploy script. This is done in the Helm templates now.
  • Update all port definitions:
    • Port numbers to match the current sample file and Ports page.
    • Use templates to define the numbers in a single location
    • Add names to all containerPorts, and use in related services
  • Simplify local block storage class naming

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds new functionality)
  • Breaking change (bug fix or new feature that breaks existing functionality)
  • Third-party dependency update
  • Documentation additions or improvements
  • Code quality improvements to existing code or test additions/updates

Applicable issues

  • This change fixes an issue: CORTX-30147

How was this tested?

Deploy/destroy cluster, run util scripts, S3 I/O, CSM API requests.

Checklist

  • The change is tested and works locally.
  • New or changed settings in the solution YAML are documented clearly in the README.md file.
  • All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change requires newer CORTX or third party image versions:

  • The image fields in solution.example.yaml have been updated to use the required versions.
  • The appVersion field of the Helm chart has been updated to use the new CORTX version.

If this change addresses a CORTX Jira issue:

  • The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)

View rendered charts/cortx/README.md

@cla-bot cla-bot bot added the cla-signed label Jun 20, 2022
- Remove generation of Server endpoints from deploy script. This is done
  in the Helm templates now.
- Update port configurations to match the upstream sample file
- Simplify local block storage class naming

Signed-off-by: Keith Pine <[email protected]>
@keithpine keithpine marked this pull request as ready for review June 20, 2022 23:20
@keithpine keithpine requested a review from a team as a code owner June 20, 2022 23:20
Copy link
Contributor

@osowski osowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keithpine keithpine merged commit 6f5721d into Seagate:integration Jun 22, 2022
@keithpine keithpine deleted the CORTX-30147_endpoint-cleanup branch June 22, 2022 20:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants