Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

keithpine
Copy link
Contributor

Description

This fixes a harmless warning message when running the destroy script, about not finding the (since removed) cortx-cloud-helm-pkg/cortx-control chart directory.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds new functionality)
  • Breaking change (bug fix or new feature that breaks existing functionality)
  • Third-party dependency update
  • Documentation additions or improvements
  • Code quality improvements to existing code or test additions/updates

Applicable issues

How was this tested?

Deploy and destroy cluster.

Additional information

Instead of hard-coding a list of directories to delete files from, just search the parent directory. This handles future chart merges. I applied the same logic to the deploy script's cleanup function.

Checklist

  • The change is tested and works locally.
  • New or changed settings in the solution YAML are documented clearly in the README.md file.
  • All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change addresses a CORTX Jira issue:

  • The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)

@cla-bot cla-bot bot added the cla-signed label May 19, 2022
@keithpine keithpine marked this pull request as ready for review May 19, 2022 18:42
@keithpine keithpine requested a review from a team as a code owner May 19, 2022 18:42
Copy link
Contributor

@osowski osowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keithpine keithpine merged commit b4bc39c into Seagate:integration May 20, 2022
@keithpine keithpine deleted the cleanup-fix branch May 20, 2022 17:32
Copy link
Contributor

@walterlopatka walterlopatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants