Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

Conversation

keithpine
Copy link
Contributor

Description

Add a default lintconf.yaml file for chart testing. This file is the default file included with ct. Adding this file helps with local linting. The chart testing action automatically sets up a default environment (apparently!), so it wasn't needed for that.

To lint, this command can be run from the root of the repository:

ct lint --config .github/linters/ct.yaml

Set ct docs for other options.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds new functionality)
  • Breaking change (bug fix or new feature that breaks existing functionality)
  • Third-party dependency update
  • Documentation additions or improvements
  • Code quality improvements to existing code or test additions/updates

How was this tested?

Ran ct locally.

Additional information

You can also specify using a default lint config with ct --lint-conf default. This would have the same result. However, adding the config file makes it explicit and isn't affect by any future upstream changes to the default. We can also customize the file in the future if necessary.

Checklist

  • The change is tested and works locally.
  • New or changed settings in the solution YAML are documented clearly in the README.md file.
  • All commits are signed off and are in agreement with the CORTX Community DCO and CLA policy.

If this change addresses a CORTX Jira issue:

  • The title of the PR starts with the issue ID (e.g. CORTX-XXXXX:)

@cla-bot cla-bot bot added the cla-signed label May 17, 2022
@keithpine keithpine marked this pull request as ready for review May 17, 2022 21:17
@keithpine keithpine requested a review from a team as a code owner May 17, 2022 21:18
Copy link
Contributor

@osowski osowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@walterlopatka walterlopatka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@keithpine keithpine merged commit eb84d96 into Seagate:integration May 17, 2022
@keithpine keithpine deleted the ct-lintconfig branch May 17, 2022 22:06
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants