Skip to content
This repository was archived by the owner on Feb 8, 2024. It is now read-only.

CORTX-34159: Address and fix Codacy issues in C file (hax.c) #2159

Merged
merged 3 commits into from
Sep 12, 2022
Merged

CORTX-34159: Address and fix Codacy issues in C file (hax.c) #2159

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dba18ae
Problem: Codacy flags issues in hax.c C code
d-nayak Sep 6, 2022
840c570
CORTX-34159 continued
d-nayak Sep 6, 2022
8e637a1
Merge branch 'main' into CORTX-34159
d-nayak Sep 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 11 additions & 4 deletions hax/hax/motr/hax.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,15 +342,22 @@ M0_INTERNAL void m0_ha_failvec_reply_send(unsigned long long hm,
static void __ha_failvec_reply_send(const struct hax_msg *hm,
struct m0_fid *pool_fid, uint32_t nr_notes)
{
struct m0_ha_link *hl = hm->hm_hl;
struct m0_halon_interface *hif = hm->hm_hc->hc_hi;
const struct m0_ha_msg *msg = &hm->hm_msg;
struct m0_ha_link *hl = NULL;
struct m0_halon_interface *hif = NULL;
const struct m0_ha_msg *msg;
struct m0_ha_msg *repmsg;
uint64_t tag;

M0_PRE(hm != NULL);

hl = hm->hm_hl;
M0_PRE(hl != NULL);

M0_PRE(hm->hm_hc != NULL);
hif = hm->hm_hc->hc_hi;

msg = &hm->hm_msg;

M0_ALLOC_PTR(repmsg);
M0_ASSERT(repmsg != NULL);
repmsg->hm_data.hed_type = M0_HA_MSG_FAILURE_VEC_REP;
Expand Down Expand Up @@ -412,11 +419,11 @@ static PyObject *nvec_to_list(const struct m0_ha_note *notes, uint32_t nr_notes)
{
uint32_t i;
const struct m0_ha_note *note;
const char *obj_name;
PyObject *list = PyList_New(nr_notes);

PyObject *hax_mod = getModule("hax.types");
for (i = 0; i < nr_notes; ++i) {
const char *obj_name;
note = &notes[i];
PyObject *fid = PyObject_CallMethod(
hax_mod, "FidStruct", "(KK)", note->no_id.f_container,
Expand Down