This repository was archived by the owner on Feb 8, 2024. It is now read-only.
CORTX-28971: update service fids along with process fids #2153
+93
−45
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
retest this please |
Shreya-18
reviewed
Aug 24, 2022
mssawant
force-pushed
the
dtm-service-fids
branch
from
ed711e3 to
3d4bdc1
Compare
Author
|
retest this please. |
A motr client restart is considered as a permanent failure and thus, if an existing motr client restarts its existing fid is updated by Hare. A motr process comprises of motr services associated to it. Interested motr modules subscribe to change in the service states, also, motr confc (configuration cache) maintains a hierarchy of processes and services, thus if a process fid changes without updating the service fids, it will not be possible to map a given process to its corresponding services. Thus, It is important to update the services fids along with its respective process fid. Solution: - Allocate service fids along with its corresponding process fid. - Make fid allocation routine generic to work for any motr configuration object. Signed-off-by: Mandar Sawant <[email protected]>
mssawant
force-pushed
the
dtm-service-fids
branch
from
3d4bdc1 to
680e3da
Compare
d-nayak
approved these changes
Sep 2, 2022
Contributor
|
Created custom build at https://eos-jenkins.colo.seagate.com/job/GitHub-custom-ci-builds/job/generic/job/custom-ci/7734/console Also in Consul kv checked all process fids and their service fids, all are in the online state. |
Author
|
Thanks @supriyachavan4398. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A motr client restart is considered as a permanent failure
and thus, if an existing motr client restarts its existing
fid is updated by Hare. A motr process comprises of motr
services associated to it. Interested motr modules subscribe
to change in the service states, also, motr confc (configuration
cache) maintains a hierarchy of processes and services, thus
if a process fid changes without updating the service fids,
it will not be possible to map a given process to its corresponding
services. Thus, It is important to update the services fids
along with its respective process fid.
Solution:
configuration object.
Signed-off-by: Mandar Sawant [email protected]