-
Notifications
You must be signed in to change notification settings - Fork 80
Update Codacy Badge #2147
Update Codacy Badge #2147
Conversation
Resolves (issue #1528)[Seagate/cortx#1528] Signed-off-by: hessio <[email protected]> Signed-off-by: Patrick Hession <[email protected]>
|
This issue/pull request has been marked as |
|
@hessio, can you elaborate a more about the problem and the fix? why codacy badge was wrong and how this PR fixes it? |
Yes sure I can elaborate - Codacy Badge is not rendering correctly on the HARE README - see below: I updated the Codacy Badge link from the Codacy app to fix the error. |
|
Thanks @hessio, in general it is good practice to have a clear commit message to understand the problem and the fix. It is evident that codacy badge was not rendering but it is good to elaborate why the badge stopped rendering or was it not rendering from the start itself. And what was actually missing and how we fixed this problem. Was there some update to the badge and do we need to look into this periodically or was it that we missed something from our side. |
I am not sure what caused the issue - to fix the issue I just went to the Codacy dashboard and copy/pasted the link to the Codacy Badge for this repo. |
|
@mssawant can we merge this PR? |
Resolves issue #1528
Signed-off-by: hessio [email protected]
Signed-off-by: Patrick Hession [email protected]
View rendered README.md