Skip to content

Add function to get browser url for Playwright #1122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 8, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -14,15 +14,15 @@
Task DoAction(MessageInfo message, ElementActionArgs action, BrowserActionResult result);
Task PressKey(MessageInfo message, string key);

Task<BrowserActionResult> InputUserText(BrowserActionParams actionParams);

Check warning on line 17 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 17 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 17 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 17 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 17 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 17 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'
Task<BrowserActionResult> InputUserPassword(BrowserActionParams actionParams);

Check warning on line 18 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 18 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 18 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 18 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 18 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 18 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'
Task<BrowserActionResult> ClickButton(BrowserActionParams actionParams);

Check warning on line 19 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 19 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 19 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 19 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 19 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 19 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'
Task<BrowserActionResult> ClickElement(BrowserActionParams actionParams);

Check warning on line 20 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 20 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 20 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 20 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 20 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 20 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'
Task<BrowserActionResult> ChangeListValue(BrowserActionParams actionParams);

Check warning on line 21 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 21 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 21 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 21 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 21 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 21 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'
Task<BrowserActionResult> CheckRadioButton(BrowserActionParams actionParams);

Check warning on line 22 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 22 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 22 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 22 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 22 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 22 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'
Task<BrowserActionResult> ChangeCheckbox(BrowserActionParams actionParams);

Check warning on line 23 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 23 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 23 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 23 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 23 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 23 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'
Task<BrowserActionResult> GoToPage(MessageInfo message, PageActionArgs args);
Task<string> ExtractData(BrowserActionParams actionParams);

Check warning on line 25 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 25 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (windows-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 25 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 25 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (ubuntu-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 25 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'

Check warning on line 25 in src/Infrastructure/BotSharp.Abstraction/Browsing/IWebBrowser.cs

View workflow job for this annotation

GitHub Actions / build (macos-latest)

'BrowserActionParams' is obsolete: 'This class is deprecated, use BrowserActionArgs instead.'
Task<T> EvaluateScript<T>(string contextId, string script);
Task CloseBrowser(string contextId);
Task<bool> IsBrowserClosed(string contextId);
Expand All @@ -30,4 +30,5 @@
Task<BrowserActionResult> SendHttpRequest(MessageInfo message, HttpRequestParams actionParams);
Task<BrowserActionResult> GetAttributeValue(MessageInfo message, ElementLocatingArgs location);
Task<BrowserActionResult> SetAttributeValue(MessageInfo message, ElementLocatingArgs location);
string GetCurrentUrl(MessageInfo message);
}
Original file line number Diff line number Diff line change
Expand Up @@ -17,4 +17,11 @@ public async Task<string> ExtractData(BrowserActionParams actionParams)

return answer;
}
public string GetCurrentUrl(MessageInfo message)
{
var page = _instance.GetPage(message.ContextId);
if (page == null)
return string.Empty;
return page.Url;
}
}
Loading