Fix UndefVarError for generate_ODENLStepData with nlstep=true #4076
+15
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a function stub in ModelingToolkitBase that throws a helpful error message when `nlstep=true` is used without ModelingToolkit loaded. ModelingToolkit then overrides this stub with the actual implementation. This fixes the issue where calling `ODEProblem(sys, u0, tspan, p; nlstep=true)` would fail with `UndefVarError: generate_ODENLStepData not defined` because the function was defined in ModelingToolkit but called from ModelingToolkitBase. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
ChrisRackauckas-Claude
force-pushed
the
fix-nlstep-generate_ODENLStepData-stub
branch
from
a6257ed to
4f4bb9b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
nlstep=trueis used without ModelingToolkit loadedMTKBase.generate_ODENLStepDataProblem
When calling
ODEProblem(sys, u0, tspan, p; nlstep=true), the code fails with:This happens because:
generate_ODENLStepDatais defined inModelingToolkit/src/systems/solver_nlprob.jlModelingToolkitBase/src/problems/odeproblem.jl:46ModelingToolkitBasemodule scopeSolution
ModelingToolkitBasethat throws a helpful error messageModelingToolkitoverride the stub by definingMTKBase.generate_ODENLStepDataTest plan
nlstep=trueworks when ModelingToolkit is loaded🤖 Generated with Claude Code