feat: allow calling generate_control_function with unsimplified system
#3699
+14
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
baggepinnen
reviewed
Jun 5, 2025
| isempty(inputs) && @warn("No unbound inputs were found in system.") | ||
| if !iscomplete(sys) |
There was a problem hiding this comment.
sys may be complete without being mtkcompiled?
There was a problem hiding this comment.
ModelingToolkit.isscheduled is for structural simplification, you can complete without that.
There was a problem hiding this comment.
I assumed the user may provide a handwritten model in the correct format that they complete without running mtkcompile. If this is not a case we want to handle, then I can just use isscheduled.
|
|
Co-authored-by: Fredrik Bagge Carlson <[email protected]>
AayushSabharwal
force-pushed
the
as/generate-control-func
branch
from
cbb4f22 to
7b87047
Compare
ChrisRackauckas
approved these changes
Jun 9, 2025
|
This PR is also necessary to make docs pass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.