Skip to content

release.yaml does not handle absolute paths for manifestURI #284

@davidcassany

Description

@davidcassany

The manifestURI does not handle absolute paths for file:// type. It should either error out with a meaningful message if they are not supported or actually enable loading an absolute path.

The path is always rebased on configuration directory path without checking if it is already an absolute path.

absConfDir, err := filepath.Abs(configDir)
if err != nil {
return fmt.Errorf("calculate absolute directory: %w", err)
}
r.ManifestURI = filepath.Join(fileSource, absConfDir, strings.TrimPrefix(r.ManifestURI, fileSource))

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions