-
Notifications
You must be signed in to change notification settings - Fork 36
Deployment: Dockerfile and Smithery config #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds deployment support for the MCP Claude Code server on Smithery using Docker and a configuration file, and updates documentation to guide installation through Smithery.
- Introduces a
Dockerfileto containerize the server. - Adds
smithery.yamldescribing start commands and configuration schema. - Updates
README.mdwith a Smithery badge and install instructions.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| smithery.yaml | Defines startCommand, config schema, examples |
| README.md | Adds badge and Smithery install instructions |
| Dockerfile | Sets up Python container and default command |
Comments suppressed due to low confidence (1)
README.md:54
- [nitpick] Double-check that
npx -yis a valid flag for the Smithery CLI; if the CLI uses a different confirm flag (e.g.,--yes), update the command accordingly.
npx -y @smithery/cli install @SDGLBL/claude-code --client claude
| description: LLM model name in LiteLLM format | ||
| agentMaxTokens: | ||
| type: number | ||
| default: null |
Copilot
AI
May 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JSON Schema sets type: number but uses default: null, which violates the schema; consider allowing null in the type (e.g., type: ["number","null"]) or providing a numeric default.
| default: null | |
| default: 1024 |
| WORKDIR /app | ||
|
|
||
| # Copy project files | ||
| COPY . . |
Copilot
AI
May 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] Consider adding a .dockerignore to exclude unnecessary files (e.g., docs, tests, local configs) from the build context to reduce image size and build time.
| @@ -1,5 +1,7 @@ | |||
| # MCP Claude Code | |||
|
|
|||
| [](https://smithery.ai/server/@SDGLBL/claude-code) | |||
Copilot
AI
May 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The badge uses generic alt text; consider updating it to something more descriptive (e.g., Smithery deployment status badge).
| [](https://smithery.ai/server/@SDGLBL/claude-code) | |
| [](https://smithery.ai/server/@SDGLBL/claude-code) |
This PR adds files for deploying your MCP server on Smithery. After deployment, users can use your server over streamable HTTP (hosted on Smithery) without needing to install any dependencies.
Changes
Server Details
@SDGLBL/claude-codeAction Items
These files were automatically generated and tested by Smithery