PRD-2076: Fix isResponseGenerating behavior #9
Conversation
|
@veliseev93 please take a look |
|
@Tomass673 I see the patch applied to the |
I left them there as is, because commit from child branch will overwrite this changes |
|
|
||
| const history = chat?.chat.history; | ||
| const isResponseGenerating = !history?.messages[history.currentId].done; | ||
| const isResponseGenerating = history?.lastAssistantMessage?.done !== true; |
There was a problem hiding this comment.
Changes related to lastAssistantMessage cause a bug when switching message history. If we return to an old chat thread, the input becomes disabled.
| if (!modelId) return; | ||
|
|
||
| // mark message as not completed | ||
| patchChatQueryData(chatId, { |
There was a problem hiding this comment.
I think this change is enough to fix the original bug, why do we need the rest of the changes?
Task: https://app.clickup.com/t/24336023/PRD-2076?comment=90150176676710