fix: User roles showing on the message header after opening user card, but with "Show roles" setting/preference disabled #37984

gabriellsh · 2025-12-26T20:48:42Z

Proposed changes (including videos or screenshots)

The setting and preference were being used to disable a useQuery that loads the roles, which populate a zustand store that is then consumed to show the data. The issue was that although that query was being disabled, other places can still load that data (such as the userCard) and also update the same store, but the flag wasn't being used to hide the roles in the UI, it just disabled the query. This caused the roles to become visible in the message after another place loads such information.

Issue(s)

CORE-1592

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Bug Fixes
- Fixed message roles display condition to ensure they only appear when explicitly enabled and when roles exist in the message.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

dionisio-bot · 2025-12-26T20:48:44Z

Looks like this PR is not ready to merge, because of the following issues:

This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

changeset-bot · 2025-12-26T20:48:47Z

⚠️ No Changeset found

Latest commit: df194e0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2025-12-26T20:49:07Z

Walkthrough

The visibility condition for the MessageRoles component in MessageHeader has been updated to require both the showRoles flag and at least one role present before rendering, adding an additional gate to the previous length-only check.

Changes

Cohort / File(s)	Summary
Message Header Rendering Logic `apps/meteor/client/components/message/MessageHeader.tsx`	Tightened MessageRoles visibility condition from `roles.length > 0` to `showRoles && roles.length > 0`, adding explicit flag check before component renders

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through render trees,
Where roles once showed with careless ease,
Now showRoles stands as gatekeeper true,
No more will hidden flags slip through! 🐰✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately describes the main bug being fixed: roles showing on message header despite disabled 'Show roles' setting.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

✨ Finishing touches

📝 Generate docstrings

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix/showRoles

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

cubic-dev-ai

No issues found across 1 file

codecov · 2025-12-26T21:02:58Z

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.60%. Comparing base (c805070) to head (df194e0).

Additional details and impacted files

@@             Coverage Diff             @@
##           develop   #37984      +/-   ##
===========================================
- Coverage    70.65%   70.60%   -0.06%     
===========================================
  Files         3143     3143              
  Lines       108693   108693              
  Branches     19557    19545      -12     
===========================================
- Hits         76797    76742      -55     
- Misses       29886    29950      +64     
+ Partials      2010     2001       -9

Flag	Coverage Δ
e2e	`60.18% <100.00%> (+<0.01%)`	⬆️
e2e-api	`47.43% <ø> (-1.06%)`	⬇️
unit	`71.71% <100.00%> (-0.04%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

github-actions · 2025-12-26T21:15:31Z

📦 Docker Image Size Report

📈 Changes

Service	Current	Baseline	Change
sum of all images	1.1GiB	1.1GiB	+11MiB
rocketchat	355MiB	345MiB	+11MiB
omnichannel-transcript-service	132MiB	132MiB	+99B
queue-worker-service	132MiB	132MiB	+428B
ddp-streamer-service	126MiB	126MiB	+405B
account-service	113MiB	113MiB	+809B
authorization-service	111MiB	111MiB	-1.1KiB
presence-service	111MiB	111MiB	+874B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 22:18", "12/17 21:04", "12/18 23:12", "12/19 23:27", "12/20 21:03", "12/22 18:54", "12/23 16:16", "12/24 19:38", "12/25 17:51", "12/26 13:18", "12/26 21:15 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]

Statistics (last 30 days):

📊 Average: 1.5GiB
⬇️ Minimum: 1.2GiB
⬆️ Maximum: 1.6GiB
🎯 Current PR: 1.1GiB

ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

Tag: pr-37984
Baseline: develop
Timestamp: 2025-12-26 21:15:30 UTC
Historical data points: 30

Updated: Fri, 26 Dec 2025 21:15:31 GMT

fix roles being shown when loaded from other components

df194e0

gabriellsh added this to the 8.1.0 milestone Dec 26, 2025

gabriellsh requested a review from a team as a code owner December 26, 2025 20:48

cubic-dev-ai bot reviewed Dec 26, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix: User roles showing on the message header after opening user card, but with "Show roles" setting/preference disabled #37984

fix: User roles showing on the message header after opening user card, but with "Show roles" setting/preference disabled #37984

gabriellsh commented Dec 26, 2025 •

edited by atlassian bot

Loading

Uh oh!

dionisio-bot bot commented Dec 26, 2025

Uh oh!

changeset-bot bot commented Dec 26, 2025

Uh oh!

coderabbitai bot commented Dec 26, 2025 •

edited

Loading

Uh oh!

cubic-dev-ai bot left a comment

Uh oh!

codecov bot commented Dec 26, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Dec 26, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

fix: User roles showing on the message header after opening user card, but with "Show roles" setting/preference disabled #37984

Are you sure you want to change the base?

fix: User roles showing on the message header after opening user card, but with "Show roles" setting/preference disabled #37984

Conversation

gabriellsh commented Dec 26, 2025 • edited by atlassian bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes (including videos or screenshots)

Issue(s)

Steps to test or reproduce

Further comments

Summary by CodeRabbit

Uh oh!

dionisio-bot bot commented Dec 26, 2025

Uh oh!

changeset-bot bot commented Dec 26, 2025

⚠️ No Changeset found

Uh oh!

coderabbitai bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Poem

Pre-merge checks and finishing touches

Uh oh!

cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

github-actions bot commented Dec 26, 2025

📦 Docker Image Size Report

📈 Changes

📊 Historical Trend

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

gabriellsh commented Dec 26, 2025 •

edited by atlassian bot

Loading

coderabbitai bot commented Dec 26, 2025 •

edited

Loading

codecov bot commented Dec 26, 2025 •

edited

Loading