Deserialization/validation unit tests #665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tests to validate that deserialization and validation will catch invalid bitmaps.
If we allow negative container counts, we can end up walking backwards before the beginning of the buffer.
|
I'll be issuing a patch release. |
Dr-Emann
added a commit
to Dr-Emann/roaring-rs
that referenced
this pull request
Apr 16, 2025
Based on tests added in CRoaring at <RoaringBitmap/CRoaring#665>
Dr-Emann
added a commit
to Dr-Emann/roaring-rs
that referenced
this pull request
Apr 17, 2025
Based on tests added in CRoaring at <RoaringBitmap/CRoaring#665>
Dr-Emann
added a commit
to Dr-Emann/roaring-rs
that referenced
this pull request
Apr 19, 2025
Based on tests added in CRoaring at <RoaringBitmap/CRoaring#665>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add some unit tests for deserialization/validation.
This also does add a small fix to the
ra_portable_deserialize_sizefunction to not allow negative container counts.Related to #662