We are vertigo

composer.json

@@ -21,7 +21,7 @@
     "bin-dir": "bin/"
   },
   "require": {
-    "rhubarbphp/rhubarb": "1.0.x-dev@dev"
+    "rhubarbphp/rhubarb": "*"
   },
   "require-dev": {
     "rhubarbphp/custard" : "^1.0.4",

src/Collections/Collection.php

@@ -398,7 +398,7 @@ public function filter(Filter $filter)
      * Where repository specific optimisation is available this will be leveraged to run the batch
      * update at the data source rather than iterating over the items.
      *
-     * @param  Array $propertyPairs An associative array of key value pairs to update
+     * @param  array $propertyPairs An associative array of key value pairs to update
      * @param  bool $fallBackToIteration If the repository can't perform the action directly, perform the update by iterating over all the models in the collection. You should only pass true if you know that the collection doesn't meet the criteria for an optimised update and the iteration of items won't cause problems
      *                                  iterating over all the models in the collection. You should only pass true
      *                                  if you know that the collection doesn't meet the criteria for an optimised

src/Custard/BulkScenario.php

@@ -0,0 +1,12 @@
+<?php
+
+namespace Rhubarb\Stem\Custard;
+
+/**
+ * Bulk scenarios are ignored unless the bulk flag -b is provided to the seed-data command.
+ *
+ * Bulk scenarios provide larger results sets for testing performance, paging, filtering etc.
+ */
+class BulkScenario extends Scenario
+{
+}

src/Custard/CommandHelpers/GetterOrSetterMethod.php

@@ -25,9 +25,40 @@ public static function fromReflectionMethod(\ReflectionMethod $method, $existing
         $methodName = $method->getName();
 
         if (stripos($methodName, 'get') === 0) {
+            $parameters = $method->getParameters();
+
             $wrapper->readable = true;
+            foreach ($parameters as $parameter) {
+                if (!$parameter->allowsNull()) {
+                    // If a "get" method has any non-nullable parameters, it's not a property getter
+                    $wrapper->readable = false;
+                    break;
+                }
+            }
+
+            if (!$wrapper->readable) {
+                return false;
+            }
         } elseif (stripos($methodName, 'set') === 0) {
-            $wrapper->writable = true;
+            $parameters = $method->getParameters();
+            $paramCount = count($parameters);
+
+            if ($paramCount > 0) {
+                // A "set" method must take a parameter to be a property setter
+                $wrapper->writable = true;
+
+                for ($i = 1; $i < $paramCount; $i++) {
+                    if (!$parameter->allowsNull()) {
+                        // If a "set" method has more than 1 non-nullable parameter, it's not a property setter
+                        $wrapper->writable = false;
+                        break;
+                    }
+                }
+            }
+
+            if (!$wrapper->writable) {
+                return false;
+            }
         } else {
             // Neither a getter nor a setter
             return false;

src/Custard/DescribedDemoDataSeederInterface.php

@@ -0,0 +1,27 @@
+<?php
+
+namespace Rhubarb\Stem\Custard;
+
+use Symfony\Component\Console\Output\Output;
+
+interface DescribedDemoDataSeederInterface extends DemoDataSeederInterface
+{
+    /**
+     * Describes the test scenarios provided by this seeder.
+     *
+     * The $output interface has a number of useful styles predefined:
+     *
+     * <critical> Red and bold
+     * <bold> Bold
+     * <blink> Blinking (not supported everywhere)
+     *
+     * Other options can be defined and the defaults provided by Symfony are
+     * still present. You can read more at the link below:
+     *
+     * https://symfony.com/doc/current/console/coloring.html
+     *
+     * @param Output $output
+     * @return mixed
+     */
+    public function describeDemoData(Output $output);
+}

src/Custard/Scenario.php

@@ -0,0 +1,55 @@
+<?php
+
+namespace Rhubarb\Stem\Custard;
+
+use Symfony\Component\Console\Output\OutputInterface;
+
+class Scenario
+{
+    /**
+     * @var callable $seedScenario
+     */
+    private $seedScenario;
+
+    /**
+     * @var ScenarioDescription $scenarioDescription
+     */
+    private $scenarioDescription;
+
+    /**
+     * @var string
+     */
+    private $name;
+
+    /**
+     * Scenario constructor.
+     * @param string $name of the scenario
+     * @param callable $seedScenario callback, a ScenarioDescription will be given as the first parameter
+     *
+     */
+    public function __construct(string $name, callable $seedScenario)
+    {
+        $this->seedScenario = $seedScenario;
+        $this->scenarioDescription = new ScenarioDescription();
+        $this->name = $name;
+    }
+
+    /**
+     * @param OutputInterface $output
+     * Run the data seeder and describe what happened to $output
+     */
+    public function run(OutputInterface $output)
+    {
+        $seedScenario = $this->seedScenario;
+        $seedScenario($this->scenarioDescription);
+        $this->scenarioDescription->describe($output);
+    }
+
+    /**
+     * @return string
+     */
+    public function getName(): string
+    {
+        return $this->name;
+    }
+}

src/Custard/ScenarioDataSeeder.php

@@ -0,0 +1,77 @@
+<?php
+
+namespace Rhubarb\Stem\Custard;
+
+use Symfony\Component\Console\Output\OutputInterface;
+
+abstract class ScenarioDataSeeder implements DemoDataSeederInterface
+{
+    private static $scenarioCount = 1;
+
+    private static $alreadyRan = [];
+
+    /**
+     * @return array|DemoDataSeederInterface[]
+     */
+    protected function getPreRequisiteSeeders()
+    {
+        return [];
+    }
+
+    /**
+     * A hook for logic to run before each scenario
+     * @param Scenario $scenario
+     */
+    protected function beforeScenario(Scenario $scenario)
+    {
+    }
+
+    /**
+     * A hook for logic to run after each scenario
+     * @param Scenario $scenario
+     */
+    protected function afterScenario(Scenario $scenario)
+    {
+    }
+
+    public function seedData(OutputInterface $output, $includeBulk = false)
+    {
+        $class = get_class($this);
+        if (in_array($class, self::$alreadyRan)) {
+            return;
+        }
+
+        self::$alreadyRan[] = $class;
+
+        foreach ($this->getPreRequisiteSeeders() as $seeder) {
+            if (is_string($seeder)) {
+                $seeder = new $seeder();
+            }
+
+            if (!($seeder instanceof DemoDataSeederInterface)) {
+                throw new \InvalidArgumentException(get_class($seeder) . " does not extend DemoDataSeederInterface.");
+            }
+
+            $seeder->seedData($output, $includeBulk);
+        }
+
+        foreach ($this->getScenarios() as $scenario) {
+            if ($includeBulk || !($scenario instanceof BulkScenario)) {
+                $this->beforeScenario($scenario);
+
+                $output->writeln("");
+                $output->writeln("<comment>Scenario " . self::$scenarioCount . ": <bold>" . $scenario->getName() . '</bold></comment>');
+                $output->writeln(str_repeat('-', 11 + strlen(self::$scenarioCount) + strlen($scenario->getName())));
+                $scenario->run($output);
+                self::$scenarioCount++;
+
+                $this->afterScenario($scenario);
+            }
+        }
+    }
+
+    /**
+     * @return Scenario[]
+     */
+    abstract function getScenarios(): array;
+}

src/Custard/ScenarioDescription.php

@@ -0,0 +1,32 @@
+<?php
+
+namespace Rhubarb\Stem\Custard;
+use Symfony\Component\Console\Output\OutputInterface;
+
+class ScenarioDescription
+{
+    /**
+     * @var string[] message lines to write
+     */
+    private $lines = [];
+
+    /**
+     * @param string $line to write
+     * @param string $spacer indentation 
+     * @return $this for the fluent pattern
+     */
+    public function writeLine(string $line, $spacer = "   ")
+    {
+        $this->lines[] = $spacer . $line;
+        return $this;
+    }
+
+    /**
+     * @param OutputInterface $output
+     * Write all oif the lines
+     */
+    public function describe(OutputInterface $output)
+    {
+        $output->writeln($this->lines);
+    }
+}