fix(eip1559): use hex number for eth_feehistory 'blockcount' parameter #765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
KolevDarko,
benjlevesque,
bertux and
leoslr
KolevDarko
approved these changes
Feb 8, 2022
benjlevesque
approved these changes
Feb 9, 2022
bertux
changed the title
Contributor
|
So why not switch first to Alchemy RPC ? |
bertux
approved these changes
Feb 15, 2022
Contributor
Author
Contributor
Author
|
Marking this as Draft, PR is stale |
Closed
alexandre-abrioux
force-pushed
the
fee-history-hex
branch
from
bffa734 to
7a12685
Compare
alexandre-abrioux
changed the title
Contributor
Author
|
rebased to fix conflicts following refactor in #931 |
Merged
github-actions
bot
requested review from
MantisClone,
benjlevesque and
kevindavee
benjlevesque
approved these changes
Mar 8, 2023
Contributor
Author
|
rainbow-me/fee-suggestions#25 has been merged, and the lib has been updated by @leoslr in #1072, merging this now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 rainbow-me/fee-suggestions#25 is needed before merging this PR.
Description of the changes
Quicknode's RPC servers do not allow the use of an integer for the
blockCountargument ofeth_feeHistory.Indeed, the doc specifies that it should be an hexadecimal number:
https://infura.io/docs/ethereum#operation/eth_feeHistory
Infura and Alchemy are more permissive in this regard.
This change will use the
hexstring instead of an integer to check ifeth_feeHistoryis supported on the RPC backend.We need to wait for an update of the
rainbow-me/fee-suggestionslibrary before merging this because this library is using an integer and not ahexstring in its RPC calls. If we merged this PR right away we would generate errors when running the request-node against Quicknode's backend.