Skip to content

OperationConcatTest.testNestedAsyncConcat failed #581

Closed
@akarnokd

Description

@akarnokd

While working on a fix for #577 I've run into a test failure (happened randomly):

org.mockito.exceptions.verification.VerificationInOrderFailure: 
Verification in order failure
Wanted but not invoked:
observer.onCompleted();
-> at rx.operators.OperationConcatTest.testNestedAsyncConcat(OperationConcatTest.java:259)
Wanted anywhere AFTER following interaction:
observer.onNext("nine");
-> at rx.operators.SafeObserver.onNext(SafeObserver.java:121)

    at rx.operators.OperationConcatTest.testNestedAsyncConcat(OperationConcatTest.java:259)

It appears the observer.onCompleted() in L195 races with the test inOrder.verify(observer, times(1)).onCompleted(); on L259. Adding a latch after L195 and before L259 seems to be a way to fix this, but I'm not sure of whether this is rather an issue with concat (I see plenty of questionable things in there too).

Thoughts?

Metadata

Metadata

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions