Skip to content

Conversation

@Javey
Copy link
Contributor

@Javey Javey commented Oct 13, 2016

Everyone is discussing serialization #20 #31 , it's complex. How about this simple PR?

Fixed:

  1. Any attribute can be stringified if you set it by setAttribute. So :
    • div.setAttribute('data-null', null) should be serialized to <div data-null="null"></div> instead of <div data-null=""></div>
    • div.setAttribute('data-number', 0) should be serialized to <div data-number="0"></div> instead of <div data-number=""></div>
  2. The false property should not be serialized. So:
    • option.selected = false should be serialized to <option></option> instead of <option selected=""></option>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant