Skip to content

Update the packet more often #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 20, 2019

Conversation

Martmists-GH
Copy link
Member

This will improve accuracy in overlay

This will improve accuracy in overlay
@IamEld3st
Copy link
Member

Is this okay to merge?

@tarehart
Copy link
Contributor

You're calling from overlay.html to python at 60Hz which was a CPU killer for me. I reduced that frequency dramatically to make the overlay a better citizen while I was streaming. We should probably find the right frequency for that expensive call, and do these updates at a matching frequency because even though it's fairly cheap, there's no point in exceeding the other rate, I think.

@IamEld3st
Copy link
Member

At this moment I am considering switching this the other way around... aka create JS "interface" that can also be called from the python side... add events like on goal on kickoff on end JS events that get called from python side.
Hopefully this would make it easier on the cpu?

@tarehart
Copy link
Contributor

Yeah, that's a good idea!

@Martmists-GH
Copy link
Member Author

Odd, I had no issues at all with a higher refresh rate

@IamEld3st
Copy link
Member

Currently merging... Issue will be fixed in an incoming PR...

@IamEld3st IamEld3st merged commit 591c370 into RLBot:tournament-overlay Mar 20, 2019
@Martmists-GH Martmists-GH deleted the patch-1 branch March 20, 2019 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants