Skip to content

Gh pages.msg #171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Vladlukhanin merged 4 commits into from
Oct 18, 2016
Merged

Gh pages.msg #171

Vladlukhanin merged 4 commits into from
Oct 18, 2016

Conversation

@Vladlukhanin
Copy link
Contributor

@Vladlukhanin Vladlukhanin commented Oct 18, 2016

Make sure that you wrote the tests for your proposed changes and the existing test was success.

Made/Proposed changes:
(Don’t use general words, describe changes in details)

  • methods QB.chat .send() and QB.chat .sendSystemMessage() return message.id

How should this be manually tested?

Does the documentation need an update?

@dimaspirit
Copy link
Contributor

dimaspirit commented Oct 18, 2016

Don't forget to write in docs

@Vladlukhanin Vladlukhanin merged commit d552887 into gh-pages Oct 18, 2016
@dimaspirit dimaspirit deleted the gh-pages.msgId branch November 23, 2016 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Vladlukhanin @dimaspirit