Remove op and wire dialects #548
Conversation
david-pl
added
the
breaking
|
|
||
|
|
||
| @wire.dialect.register | ||
| @qubit.dialect.register |
There was a problem hiding this comment.
@johnzl-777 I'm not sure if this is correct. Do we even still need the WrapAnalysis?
There was a problem hiding this comment.
I think the WrapOpSiteAnalysis isn't necessary anymore but the WrapAddressAnalysis is. WrapAnalysis just lets me store analysis results in the statement hints so that other rewrite rules can access them (for example, in SquinNoiseToStim I query the hints for address analysis data).
I think one could get away without wrapping altogether? The cost is that I have to manually feed the analysis results to the rules that need the data
There was a problem hiding this comment.
Okay, thanks for clarifying. Then I'm leaving this as is. The site analysis is already gone altogether, since we don't have Op anymore, it doesn't make any sense.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
|
Do not have this blocked #508. That PR will be simplfied a bit after this is merged. I can take care of merging any changes. |
johnzl-777
left a comment
johnzl-777
left a comment
There was a problem hiding this comment.
Farewell wire and op, may your contributions to bloqade-circuit never be forgotten ❤️
This is the final step of the refactor in #492. We need to merge #508 first, however.