Fixed SSC not save ateArtisanBread, usedAegisCrystal, usedAegisFruit, usedArcaneCrystal, usedGalaxyPearl, usedGummyWorm, usedAmbrosia, unlockedSuperCart, enabledSuperCart flags, and Server will correct read them.
#2758
Conversation
…ruit`, `usedArcaneCrystal`, `usedGalaxyPearl`, `usedGummyWorm`, `usedAmbrosia`, `unlockedSuperCart`, `enabledSuperCart` flags, and Server will correct read them.
|
LGTM, as far as i can see this is functionally correct |
|
Fixed Server not tracks deaths, Now players can be viewed with the |
|
@hufang360 in the future, please try to submit a PR for only one thing at a time. We can't merge this branch directly now because there's an approval for what @punchready reviewed but not a PR for the subsequent changes, which are unrelated. |
OK. What can i do? |
drunderscore
left a comment
drunderscore
left a comment
There was a problem hiding this comment.
SSC changes are fine, I've review and tested them and couldn't find anything wrong.
As for the death commands, just testing out the PVE death counter something seems wrong -- if we're going to store deaths into our SSC (the database), then we should be sure to never honor the client's values, and properly respect the ones we have.
Same complaint as particles earlier -- if this were two PRs, it would be much easier to merge the SSC changes and wait for the death changes, but now both changes are in limbo :(
| /// PlayerSpawn - When a player spawns | ||
| /// </summary> | ||
| public static HandlerList<SpawnEventArgs> PlayerSpawn = new HandlerList<SpawnEventArgs>(); | ||
| private static bool OnPlayerSpawn(TSPlayer player, MemoryStream data, byte pid, int spawnX, int spawnY, int respawnTimer, PlayerSpawnContext spawnContext) |
There was a problem hiding this comment.
Parameter names should be lowerCamelCase
TShockAPI/Commands.cs
Outdated
|
|
||
| if (string.IsNullOrEmpty(tag)) | ||
| { | ||
| args.Player.SendInfoMessage("There are currently no players online."); |
TShockAPI/Commands.cs
Outdated
|
|
||
| if (string.IsNullOrEmpty(tag)) | ||
| { | ||
| args.Player.SendInfoMessage("There are currently no players online."); |
hufang360
force-pushed
the
general-devel
branch
from
24f3e92 to
ca93fa6
Compare
|
@hufang360 this is ready-for-merge; if you don't want to you don't need to resolve conflicts as we can still merge (it's just the changelog). The other changes that were in this PR can be merged separately, if that's okay with you! |
Thanks. The death counter seems wrong, I rollback the commit, Now it only contain one PR. |
4 participants
Fixed SSC not save
ateArtisanBread,usedAegisCrystal,usedAegisFruit,usedArcaneCrystal,usedGalaxyPearl,usedGummyWorm,usedAmbrosia,unlockedSuperCart,enabledSuperCartflags, and Server will correct read them.