Skip to content

Conversation

@guopengf
Copy link
Contributor

@guopengf guopengf commented Aug 5, 2024

Fixes #7988 .

Description

Refactor DiffusionModelUNetMaisi to use monai core components.

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: Pengfei Guo <[email protected]>
@guopengf guopengf linked an issue Aug 5, 2024 that may be closed by this pull request
@guopengf guopengf marked this pull request as ready for review August 9, 2024 22:13
@guopengf guopengf self-assigned this Aug 11, 2024
Signed-off-by: Pengfei Guo <[email protected]>
@KumoLiu
Copy link
Contributor

KumoLiu commented Aug 12, 2024

/build

@KumoLiu KumoLiu merged commit 250c18d into Project-MONAI:dev Aug 12, 2024
@KumoLiu KumoLiu added this to the Refactor MAISI [P0 v1.4] milestone Aug 19, 2024
rcremese pushed a commit to rcremese/MONAI that referenced this pull request Sep 2, 2024
Fixes Project-MONAI#7988 .

### Description

Refactor DiffusionModelUNetMaisi to use monai core components. 

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: Pengfei Guo <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

Refactor MAISI networks to use monai core components

2 participants