UFS3 setting is not dynamic enough

[sunflower2333]

It’s hardcoded and default to ufs3 in AndromedaPkg DEC and i don't know why.
Many old devices has ufs2 and default set to ufs3 will cause issue.
Please use a more dynamic way to get ufs version and set instead of hardcoding in dsc/dec.

[halal-beef]

Hardcoded to UFS3 because:

UFS3 Device booting with UFS2 Spec -> Boots -> Overvolting UFS -> Future issues

UFS2 Device booting with UFS3 Spec -> Doesn't boot -> Switch PCD -> Boot

its hardcoded purely for safety

[qaz6750]

It seems that on the currently mainstream-supported HANA platform, there is no way （dynamic way） to figure out whether the UFS chip is UFS 3 or UFS 2.

Moreover, the versions of xbl used by each device are different, and there is no guarantee that every device will have a way to dynamically obtain information about whether it is UFS 2 or UFS 3.

[halal-beef]

iirc there is a reg you can read to get UFS version and it'll return 0x300 for UFS 3 and whatnot but to read it im pretty sure youd need the ufs to be powered up

[sunflower2333]

Hardcoded to UFS3 because:

UFS3 Device booting with UFS2 Spec -> Boots -> Overvolting UFS -> Future issues

UFS2 Device booting with UFS3 Spec -> Doesn't boot -> Switch PCD -> Boot

its hardcoded purely for safety

have you encontered any over voltage issue?

[sunflower2333]

like burn or something else

[remtrik]

have you encontered any over voltage issue?

My 10 vayus died because of that. I thought it was a motherboard issue, but after noticing that all devices use ufs2 settings and disassembling vayus I found 8 out of 10 ufs chips being completely fried(other 2 are barely working)

[remtrik]

Regarding as to why it's hardcoded to UFS3, it was stated in the initial PR

[sunflower2333]

have you encontered any over voltage issue?

My 10 vayus died because of that. I thought it was a motherboard issue, but after noticing that all devices use ufs2 settings and disassembling vayus I found 8 out of 10 ufs chips being completely fried(other 2 are barely working)

sound normal on vayu
I just checked ACPI and only 0.4v voltage difference.
UFS3 VCC is 2.5V, UFS 2 VCC is 2.9V

As what UFS3.1 spec say:

VCC has 2 different ranges. It's up to the vendor anyway.

[sunflower2333]

JESD220E-UFS3.1.pdf

[remtrik]

#454 (comment)

Returning to this theme, I wonder is this true for both WP and LA or just the WP. Because 2023 Moorea LA and Rennell LA/WP BSP doesn't have that