Fix #418: Debugger should retry if extension isn't loaded yet #429
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change adds retry logic to debugAdapter.ts so that it will check for the language server's session file once a second for 30 seconds until it appears. If the file appears debugging will resume, otherwise a specific error message will be displayed saying that the debugger timed out waiting for the extension to initialize. This is a temporary fix until we get to leverage VS Code 1.9.0's new debugger launch capabilities.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds retry logic to debugAdapter.ts so that it will check for
the language server's session file once a second for 30 seconds until it
appears. If the file appears debugging will resume, otherwise a specific
error message will be displayed saying that the debugger timed out waiting
for the extension to initialize.
This is a temporary fix until we get to leverage VS Code 1.9.0's new
debugger launch capabilities.