Add new "attach" and "interactive" debugging configurations #423
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rkeithhill
reviewed
Jan 10, 2017
| @@ -160,7 +160,7 @@ | |||
|
|
|||
| "configurationSnippets": [ | |||
| { | |||
| "label": "PowerShell: Launch Current File Configuration", | |||
| "label": "PowerShell: Launch Current Script", | |||
There was a problem hiding this comment.
Script is better than file but you might want to leave in "Configuration" at the end. This is what I see for the other langs that support debug configuration snippets:
There was a problem hiding this comment.
Yeah, you're right, I'll change it back
This change adds new configuration possibilies for PowerShell debugging in the extension. The first is simply to allow the user to not specify a script file in their "launch" configuration; when such a configuration is launched it merely drops them into an interactive shell in the Debug Console where they can enter whatever commands they like. The other new configuration is a new "attach" configuration which allows the user to specify a process ID or a remote computer and process ID to which the debugger should be attached when it launches. This provides a smooth attach/detach experience so that the user does not need to go into an interactive console to initiate the Enter-PSSession and Enter-PSHostProcess commands manually (though this is still possible and supported in interactive debugging mode).
This change adds a handler for the editor/closeFile request which is part of the editor extensibility model of PowerShell Editor Services. This request currently gets fired when the user exits a remote debugging session where a remote file had been opened. It will later be exposed through the $psEditor API.
This change adds the PSAvoidUsingAliases rule back to our example PSScriptAnalyzer configuration file so that it can be used for example and testing purposes.
This change adds runspace connection details to the status bar indicator when the user enters a remote session or PowerShell process through the editing session.
daviwil
force-pushed
the
daviwil/debug-attach
branch
from
7ede29b to
d95a375
Compare
|
LGTM |
|
Thanks Keith! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change adds new configuration possibilies for PowerShell debugging in
the extension. The first is simply to allow the user to not specify a
script file in their "launch" configuration; when such a configuration is
launched it merely drops them into an interactive shell in the Debug
Console where they can enter whatever commands they like.
The other new configuration is a new "attach" configuration which allows
the user to specify a process ID or a remote computer and process ID to
which the debugger should be attached when it launches. This provides a
smooth attach/detach experience so that the user does not need to go into
an interactive console to initiate the Enter-PSSession and
Enter-PSHostProcess commands manually (though this is still possible and
supported in interactive debugging mode).