Snippets discussion - bracing style

[rkeithhill]

I (reluctantly) would like to open a discussion regarding which bracing style to use for snippets. Right now, the latest snippets file uses Allman style bracing e.g.:

function foo
{
    ...
}

But the bulk of the PowerShell code I've seen in the wild uses K&R style e.g.:

function foo {
    ...
}

I know there are details of bracing style the community at large doesn't agree upon like whether or not to use cuddled else but I do believe K&R is fairly well accepted at the "top level".

Would anyone object strenuously if I changed the snippets to use K&R?

[daviwil]

I have no objection to that since it seems to be the prevalent coding style in PowerShell. I'm not sure who wrote the original snippets but we should definitely make them conform to generally expected PowerShell coding style.

[rkeithhill]

OK we are going with K&R style which I see more often out in the wild in PowerShell scripts.

[Jaykul]

I vote K&R
With cuddled else!
Because ... code folding.

Oh, right. VS Code doesn't do that yet. :-P

[rkeithhill]

With the current snippets for if, elseif and else, you can control whether you get cuddling or not by where you invoke the snippet. The following will give you a cuddled else:

if ($foo) {
    ...
} else{tab}

And if you want standard K&R, invoke the snippet below the if statement's closing brace e.g.:

if ($foo) {
    ...
} 
else{tab}

[rkeithhill]

This has been implemented for the upcoming 0.4.0 release.

Thank you for your comment, but please note that this issue has been closed for over a week. For better visibility, consider opening a new issue with a link to this instead.