Extension incorrectly attempts x64 update on Arm64 platform

[pb5050]

I use nothing but native arm64.....

I get this alert in visual studio code (arm64) an alert about an updated version of powershell.

when clicking it tries to install x64 version instead of arm. would be nice to have an arm installer or recognize im using arm and not x64.

[schuelermine]

This seems like it's a bug in the PowerShell extension, since there is an arm64 version available.

However, if you're on Linux, it seems there's only amd64 .deb and .rpm packages available, so that may be the reason.

[andyleejordan]

We (unfortunately) have our own logic in the extension to suggest updating PowerShell. Perhaps we'll fix this bug, but frankly I've been contemplating removing that logic entirely. PowerShell already has its own logic to prompt users to update; I don't think the extension has any business adding duplicative logic on top of that, especially (as evidenced by this bug, among several) that it's buggy. It's not worth the maintenance cost.

@rjmholt @SydneyhSmith thoughts?

[andyleejordan]

Well, I thought this would be a moderately quick fix until I dug into it. It's worms all the way down with our own custom PowerShellProcessArchitecture that has no notion of ARM64, and in the end just queries the environment variable PROCESSOR_ARCHITECTURE in PowerShell...