Wrong reference highlighting and count in DSC module

[wasker]

Issue Description

I'm working on DSC module and some references are not highlighted and counted correctly.

Attached Logs

Follow the instructions in the README about capturing and sending logs.

This link ^^^ is broken.

Environment Information

Visual Studio Code

Name	Version
Operating System	Windows_NT x64 10.0.18363
VSCode	1.44.2
PowerShell Extension Version	2020.4.0

PowerShell Information

Name	Value
PSVersion	5.1.18362.752
PSEdition	Desktop
PSCompatibleVersions	1.0 2.0 3.0 4.0 5.0 5.1.18362.752
BuildVersion	10.0.18362.752
CLRVersion	4.0.30319.42000
WSManStackVersion	3.0
PSRemotingProtocolVersion	2.3
SerializationVersion	1.1.0.1

Visual Studio Code Extensions

Visual Studio Code Extensions(Click to Expand)

Extension	Author	Version
EditorConfig	EditorConfig	0.14.5
markdown-toc	AlanWalk	1.5.6
powershell	ms-vscode	2020.4.0
remote-wsl	ms-vscode-remote	0.44.2
rewrap	stkb	1.9.1
spellchecker	swyphcosmo	1.2.13
vscode-base64	adamhartford	0.1.0
vscode-guid	heaths	1.4.19
vscode-markdownlint	DavidAnson	0.34.0
vscode-typescript-tslint-plugin	ms-vscode	1.2.3

[SydneyhSmith]

@wasker thanks for opening this issue, sorry that the README link is broken we'll have to fix that...
It would be really helpful if you could also attach the logs--instructions for how to do that are here

[wasker]

Here you go:

logs.zip

[SydneyhSmith]

Thanks @wasker looks like the stack trace is here:

2020-04-22 16:08:28.295 -07:00 [ERR] Execution of the following command(s) completed with errors:

    Microsoft.PowerShell.Core\Get-Command DisableDisallowedProtocols -ErrorAction Ignore


2020-04-22 16:08:28.297 -07:00 [FTL] Failed to handle notification textDocument/hover
System.NullReferenceException: Object reference not set to an instance of an object.
   at Microsoft.PowerShell.EditorServices.Services.PowerShellContext.CommandHelpers.<GetCommandInfoAsync>d__4.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.PowerShell.EditorServices.Services.Symbols.SymbolDetails.<CreateAsync>d__12.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.PowerShell.EditorServices.Services.SymbolsService.<FindSymbolDetailsAtLocationAsync>d__17.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at Microsoft.PowerShell.EditorServices.Handlers.HoverHandler.<Handle>d__6.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at OmniSharp.Extensions.LanguageServer.Server.Pipelines.ResolveCommandPipeline`2.<Handle>d__5.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at MediatR.Pipeline.RequestExceptionProcessorBehavior`2.<Handle>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at MediatR.Pipeline.RequestExceptionProcessorBehavior`2.<Handle>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at MediatR.Pipeline.RequestExceptionActionProcessorBehavior`2.<Handle>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at MediatR.Pipeline.RequestExceptionActionProcessorBehavior`2.<Handle>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at MediatR.Pipeline.RequestPostProcessorBehavior`2.<Handle>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at MediatR.Pipeline.RequestPreProcessorBehavior`2.<Handle>d__2.MoveNext()
--- End of stack trace from previous location where exception was thrown ---
   at System.Runtime.ExceptionServices.ExceptionDispatchInfo.Throw()
   at System.Runtime.CompilerServices.TaskAwaiter.HandleNonSuccessAndDebuggerNotification(Task task)
   at OmniSharp.Extensions.JsonRpc.RequestRouterBase`1.<RouteRequest>d__9.MoveNext()
2020-04-22 16:08:28.298 -07:00 [DBG] Finished: Routing Request (22) textDocument/hover in 49ms
2020-04-22 16:08:28.641 -07:00 [DBG] Finding descriptor for textDocument/hover

[TylerLeonhardt]

I'm thinking the stack trace is not related... we're just not calculating the column correctly...

@wasker can you share what these functions are wrapped in? They seem to be indented a bit.

[TylerLeonhardt]

I have a fix for that stack trace here: PowerShell/PowerShellEditorServices#1276

[wasker]

Followed up offline with the file.