This repository was archived by the owner on Aug 17, 2021. It is now read-only.
Give PSArm block an alias-free environment so property keywords work #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjmholt
commented
Mar 31, 2021
daxian-dbw
previously approved these changes
Apr 12, 2021
I've updated the issue to describe the problem and the PR to describe the solution (the solution description not as detailed). |
kilasuit
previously approved these changes
Apr 13, 2021
| # Copyright (c) Microsoft Corporation. | ||
| # Licensed under the MIT License. | ||
|
|
||
|
|
||
| # Copyright (c) Microsoft Corporation. |
There was a problem hiding this comment.
Shouldn't need the duplicated Copyright line
| # Copyright (c) Microsoft Corporation. | ||
| # Licensed under the MIT License. | ||
|
|
||
|
|
||
| # Copyright (c) Microsoft Corporation. |
There was a problem hiding this comment.
Shouldn't need the duplicated Copyright line
test/pester/Conversion.Tests.ps1
Outdated
| # Copyright (c) Microsoft Corporation. | ||
| # Licensed under the MIT License. | ||
|
|
||
|
|
||
| # Copyright (c) Microsoft Corporation. |
There was a problem hiding this comment.
Shouldn't need the duplicated Copyright line
rjmholt
commented
Apr 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126.
In this PR, we use internal PowerShell engine APIs to tear down the aliases in each parent scope and store them while the
Armblock body is executed. When execution is complete, we then restore the alias definitions to each scope using other internal PowerShell engine APIs.