Remove PA_WIN_DS_USE_WMME_TIMER
#921
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This build flag was introduced 13 years ago to allow PortAudio users to roll back to some previous MME timer-based DirectSound implementation. As far as I can tell no-one has ever used that flag (Google returns ~0 hits for it), and presumably no-one is going to bother testing with this flag in place. Get rid of it to simplify the DS code which currently looks like an #ifdef fest.
RossBencina
added
src-dsound
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This build flag was introduced 13 years ago to allow PortAudio users to roll back to some previous MME timer-based DirectSound implementation.
As far as I can tell no-one has ever used that flag (Google returns ~0 hits for it), and presumably no-one is going to bother testing with this flag in place. Get rid of it to simplify the DS code which currently looks like an
#ifdeffest.