Fix format converter issues found by paqa_dither #1051
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use floatf() to fix non-linearity at 0.0. Always clip when doing dithering to prevent numeric wrap-around. Add extra half bit to compensate for bias when truncating.
philburk
commented
Jul 24, 2025
| @@ -574,7 +581,7 @@ static void Float32_To_Int16( | |||
|
|
|||
| while( count-- ) | |||
| { | |||
| short samp = (short) (*src * (32767.0f)); | |||
| short samp = (short) floorf(*src * (32767.0f)); | |||
There was a problem hiding this comment.
Maybe use PA_FLOAT_TO_INT32 here.
|
TODO:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use floatf() to fix non-linearity at 0.0.
Always clip when doing dithering to prevent numeric wrap-around.
Add extra half bit to compensate for bias when truncating.