Skip to content

Conversation

@f0uriest
Copy link
Member

@f0uriest f0uriest commented May 30, 2023

  • Renames some keyword arguments to plotting functions to have more consistent names, and adds some missing kwargs.
  • Also renames all instances of zeta, nzeta, nphi to just phi, which can be a float, int, or array of toroidal angles to plot.

Resolves #420

@f0uriest f0uriest marked this pull request as draft May 30, 2023 21:16
@codecov
Copy link

codecov bot commented May 30, 2023

Codecov Report

Merging #523 (0177562) into master (fcd2c0f) will increase coverage by 0.11%.
The diff coverage is 98.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #523      +/-   ##
==========================================
+ Coverage   94.09%   94.20%   +0.11%     
==========================================
  Files          75       75              
  Lines       17189    17195       +6     
==========================================
+ Hits        16174    16199      +25     
+ Misses       1015      996      -19     
Impacted Files Coverage Δ
desc/plotting.py 88.65% <98.83%> (+1.41%) ⬆️
desc/utils.py 89.50% <100.00%> (+0.29%) ⬆️

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@f0uriest f0uriest marked this pull request as ready for review July 13, 2023 23:12
Copy link
Collaborator

@rahulgaur104 rahulgaur104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems straightforward.

@f0uriest f0uriest merged commit 901e7a8 into master Jul 14, 2023
@f0uriest f0uriest deleted the rc/plotting branch July 14, 2023 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make plot kwargs uniform across different functions

5 participants