Skip to content

Conversation

@unalmis
Copy link
Collaborator

@unalmis unalmis commented Nov 25, 2025

Adds files to reproduce the results in the article.

@unalmis unalmis requested a review from rahulgaur104 November 25, 2025 15:30
@unalmis unalmis requested review from a team, YigitElma, ddudt, dpanici and f0uriest and removed request for a team November 26, 2025 00:37
@unalmis unalmis force-pushed the ku/bounce_paper branch 2 times, most recently from c2fb6c8 to ca29113 Compare November 28, 2025 10:26
Copy link
Collaborator

@dpanici dpanici left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Files all seem fine, but could you add a README.md to the subfolder that has some info on how to run/setup, even just adding one line saying something like the specific either DESC version, tag, or commit hash which was used to make the figs would be good.

@unalmis
Copy link
Collaborator Author

unalmis commented Dec 11, 2025

Files all seem fine, but could you add a README.md to the subfolder that has some info on how to run/setup, even just adding one line saying something like the specific either DESC version, tag, or commit hash which was used to make the figs would be good.

I can't do any of that until #1919 is merged to master. The commit hash will be the commit on master associated with the merge of #1919.

@YigitElma
Copy link
Collaborator

Files all seem fine, but could you add a README.md to the subfolder that has some info on how to run/setup, even just adding one line saying something like the specific either DESC version, tag, or commit hash which was used to make the figs would be good.

I can't do any of that until #1919 is merged to master. The commit hash will be the commit on master associated with the merge of #1919.

You can still create a tag for the commit you used for plots, and that tag will last forever (even if squashed). You should be able to do this

git tag -a unalmis2025 <commit-id> -m "DESC version that is used to produce results in Unalmis 2025 Paper"
git push --tags

unalmis2025 part is tag name, you can choose a name you like. The last part is a description, again change it as you like.

@unalmis unalmis changed the base branch from ku/bounce to ku/points December 16, 2025 23:03
Base automatically changed from ku/points to ku/bounce December 18, 2025 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants