Quality of life changes #398
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enum_variant_type wasn't upgraded as it will stop us from making sure that ::core is used in macros
This was referenced Jan 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upgrade the MSRV to 1.66.1: 1.66.0 was released two years ago on 15th of December 2022, and 1.66.1 is a point version released on the 10th of January 2023, only as a fix for a CVE.
Upgrade dependencies to the latest version that supports Rust v1.66.1: enum_variant_type wasn't upgraded as it will stop us from making sure that ::core is used in macros.
Remove unused dependencies: Bitflags wasn't used in the strum_tests crate.
Specify some options in the Cargo.toml files, such as the resolver version (set to 2), and the rust-version(s) for the included crates (set to 1.66.1).