update to rc.5

[PatrickJS]

merge changes from https://github.com/AngularClass/angular2-seed

Angular 2 Seed will be the simple version of this repo. Both will be updated to Webpack 2

[aminebizid]

Great!

[PatrickJS]

I have a simple version of the starter here https://github.com/AngularClass/angular2-seed that's updated to rc.5 it's where I experiment for changes in this repo

[shahmirn]

I tried to use RC5 and ran into an issue with uri.match is not a function, which is caused by _split being called on moduleId by angular, which in the case of webpack is a number.

angular/angular#10595 is a PR created by @mhamel06 to fix the issue.

[PatrickJS]

don't use moduleId in webpack

[shahmirn]

How about dependencies being used in the project that are using moduleId that we have no control over?

[PatrickJS]

@shahmirn are they public deps on github? if so can you give me a link to the repo. You would use a loader to rewrite it and remove the moduleId but I need to create it.

[mhamel06]

sorry not at computer now but I think my issue may have been from the material repo, since I still had the issue after removing my moduleIDs. this is with the latest Ng module version. https://github.com/angular/material2/blob/master/src/components/sidenav/sidenav.ts

I think ensuring that the _split function is only called with the expected type should fix the core issue.

[PatrickJS]

@mhamel06 @shahmirn
ok fixed via
https://github.com/AngularClass/angular2-seed/commit/84aacc18682bbe38631cd3c457d9e90944d6fd0e

[houko]

when rc5 will be updated in this project? @gdi2290 thank you

[snird]

@gdi2290 the seed repo uses webpack 2, is it planned to update this starter repo to webpak 2 as well?

[PatrickJS]

yup this repo will be updated to webpack2 and rc5

[DzmitryShylovich]

eta?

[paralin]

Looking forward to this, if you'd like me or the 100 other people here waiting for this to help, let us know how!

I noticed when trying to update my own project that the hot loading stuff might be a bit ?? with rc5. Because you have to declare all of the components in a single place. Are we going to make multiple modules for a project, maybe? Seems really a lot more complicated than before.