Better NaN Decimal creation #174
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes NaN Decimals get created from Decimal.dNaN instead of from components. This means that if dNaN is ever changed in the future, these lines won't need to be changed too. It is also more readable imo.
Collaborator
|
Should we do this for Infinity and -Infinity too? |
Also updated the dist files with the NaN improvements
Collaborator
|
I made the changes for Infinity and -Infinity. Let me know if we're good to merge. |
Author
|
Yep looks good! |
MathCookie17
added a commit
that referenced
this pull request
Oct 7, 2024
Also fixed #172 in the process
Collaborator
|
While I didn't technically do it by merging this pull request in GitHub (because I also added code from another request), this pull request has been merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change makes NaN Decimals get created from Decimal.dNaN instead of from components. This means that if dNaN is ever changed in the future, these lines won't need to be changed too. It is also more readable imo.