Introduce incoming message support for envelope unwrapping #7422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hazel-bohon
changed the title
hazel-bohon
changed the title
This comment was marked as off-topic.
This comment was marked as off-topic.
mauroservienti
changed the title
mauroservienti
force-pushed
the
CloudEvents
branch
from
883a7a4 to
9f82a75
Compare
mauroservienti
added a commit
to Particular/NServiceBus.Envelope.CloudEvents
that referenced
this pull request
Nov 27, 2025
mauroservienti
added a commit
to Particular/NServiceBus.Envelope.CloudEvents
that referenced
this pull request
Nov 27, 2025
This was referenced Dec 4, 2025
mauroservienti
force-pushed
the
CloudEvents
branch
from
9b71ba2 to
a8b908e
Compare
# Conflicts: # src/NServiceBus.Core/Receiving/ReceiveComponent.cs
afprtclr
force-pushed
the
CloudEvents
branch
from
a62cd95 to
a48da28
Compare
Removing CanUnwrap API
hazel-bohon
commented
Dec 15, 2025
Comment on lines
+259
to
+264
| if (exception != null) | ||
| { | ||
| meterTags.Add(new KeyValuePair<string, object?>(MeterTags.ErrorType, exception.GetType().FullName)); | ||
| } | ||
|
|
||
| totalEnvelopeUnwrappingErrors.Add(succeeded ? 0 : 1, meterTags); |
Member
There was a problem hiding this comment.
What's the scenario for the exception not null and succeeded true?
There was a problem hiding this comment.
Shouldn't be such a scenario, but I didn't want to decide the metric value based on the exception and wanted to make it explicit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.