fix(core): handle setting falsy value in proxy providers #118
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Jerry Laloan <[email protected]>
Papooch
requested changes
Jan 31, 2024
Owner
Papooch
left a comment
Papooch
left a comment
There was a problem hiding this comment.
Great catch, thank you! But please move the test case to packages/core/test/proxy-providers/proxy-providers.spec.ts to a new top-level describe block called "edge cases".
Contributor
Author
Papooch
approved these changes
Jan 31, 2024
Papooch
changed the title
Owner
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes setting a falsy value on a proxyfied object. Without the fix, the test fails with the following error when running
proxy.booleanTest = false:This behavior is documented here on MDN: