Skip to content

Conversation

@cjgajard
Copy link
Member

@cjgajard cjgajard commented Jul 9, 2024

Includes migration to terraform plugin framework for:

  • pagerduty_automation_actions_action
  • data.pagerduty_automation_actions_action
  • pagerduty_automation_actions_action_service_association
  • pagerduty_automation_actions_action_team_association
  • pagerduty_automation_actions_runner
  • pagerduty_automation_actions_runner_team_association
  • data.pagerduty_automation_actions_runner

Acceptance tests results after migration of above TF Objects...

==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccPagerDutyAutomationActionsAction -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/apiutil  [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/enumtypes        [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/rangetypes       [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/tztypes  [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/validate [no test files]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     0.544s [no tests to run]
=== RUN   TestAccPagerDutyAutomationActionsActionServiceAssociation_import
--- PASS: TestAccPagerDutyAutomationActionsActionServiceAssociation_import (25.76s)
=== RUN   TestAccPagerDutyAutomationActionsActionTeamAssociation_import
--- PASS: TestAccPagerDutyAutomationActionsActionTeamAssociation_import (12.86s)
=== RUN   TestAccPagerDutyAutomationActionsAction_import
--- PASS: TestAccPagerDutyAutomationActionsAction_import (11.77s)
=== RUN   TestAccPagerDutyAutomationActionsActionServiceAssociation_Basic
--- PASS: TestAccPagerDutyAutomationActionsActionServiceAssociation_Basic (21.72s)
=== RUN   TestAccPagerDutyAutomationActionsActionTeamAssociation_Basic
--- PASS: TestAccPagerDutyAutomationActionsActionTeamAssociation_Basic (10.97s)
=== RUN   TestAccPagerDutyAutomationActionsActionTypeProcessAutomation_Basic
--- PASS: TestAccPagerDutyAutomationActionsActionTypeProcessAutomation_Basic (17.08s)
=== RUN   TestAccPagerDutyAutomationActionsActionTypeScript_Basic
--- PASS: TestAccPagerDutyAutomationActionsActionTypeScript_Basic (16.25s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       117.283s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  1.093s [no tests to run]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccDataSourcePagerDutyAutomationActionsAction -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/apiutil  [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/enumtypes        [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/rangetypes       [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/tztypes  [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/validate [no test files]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     0.511s [no tests to run]
=== RUN   TestAccDataSourcePagerDutyAutomationActionsAction_Basic
--- PASS: TestAccDataSourcePagerDutyAutomationActionsAction_Basic (10.29s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       11.458s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  0.726s [no tests to run]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccPagerDutyAutomationActionsRunner -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/apiutil  [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/enumtypes        [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/rangetypes       [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/tztypes  [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/validate [no test files]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     0.866s [no tests to run]
=== RUN   TestAccPagerDutyAutomationActionsRunnerTeamAssociation_import
--- PASS: TestAccPagerDutyAutomationActionsRunnerTeamAssociation_import (12.56s)
=== RUN   TestAccPagerDutyAutomationActionsRunner_import
--- PASS: TestAccPagerDutyAutomationActionsRunner_import (10.77s)
=== RUN   TestAccPagerDutyAutomationActionsRunnerTeamAssociation_Basic
--- PASS: TestAccPagerDutyAutomationActionsRunnerTeamAssociation_Basic (11.35s)
=== RUN   TestAccPagerDutyAutomationActionsRunner_Basic
--- PASS: TestAccPagerDutyAutomationActionsRunner_Basic (15.61s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       50.820s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  1.139s [no tests to run]
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -count=1 -run TestAccDataSourcePagerDutyAutomationActionsRunner -timeout 120m
?       github.com/PagerDuty/terraform-provider-pagerduty       [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/apiutil  [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/enumtypes        [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/rangetypes       [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/tztypes  [no test files]
?       github.com/PagerDuty/terraform-provider-pagerduty/util/validate [no test files]
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerduty     0.514s [no tests to run]
=== RUN   TestAccDataSourcePagerDutyAutomationActionsRunner_Basic
--- PASS: TestAccDataSourcePagerDutyAutomationActionsRunner_Basic (9.45s)
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/pagerdutyplugin       10.605s
testing: warning: no tests to run
PASS
ok      github.com/PagerDuty/terraform-provider-pagerduty/util  0.738s [no tests to run]

@cjgajard cjgajard force-pushed the tpf-automation-action branch from 10554ab to edfb8c9 Compare July 12, 2024 12:13
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cjgajard Great job! This pretty good to me, let's keep it open until PagerDuty/go-pagerduty gets updated.

gopkg.in/ini.v1 v1.67.0 // indirect
)

replace github.com/PagerDuty/go-pagerduty => github.com/cjgajard/go-pagerduty v0.0.0-20240712203852-d83eacdec105
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder: drop this replace and update deps after PagerDuty/go-pagerduty gets updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants