Skip to content

Fix MB85RS256B bug in ramtron #322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
davids5 merged 1 commit into from
Sep 13, 2024
Merged

Fix MB85RS256B bug in ramtron #322

davids5 merged 1 commit into from
Sep 13, 2024

Conversation

@LCaiJie
Copy link
Contributor

@LCaiJie LCaiJie commented Sep 2, 2024

MB85RS256B Address Length Error

@dagar
Copy link
Member

dagar commented Sep 6, 2024

Is this fixed in upstream NuttX? https://github.com/apache/nuttx

@LCaiJie
Copy link
Contributor Author

LCaiJie commented Sep 7, 2024

Is this fixed in upstream NuttX? https://github.com/apache/nuttx

image

Not fixed yet, I need to push upstream first?

@davids5
Copy link
Member

davids5 commented Sep 7, 2024

yes @LCaiJie please do a PR to NuttX. The commit would be mtd:ramtron MB85RS256B address length is 2, Once it is merged. Then do a PR here with [BACKPORT] mtd:ramtron MB85RS256B address length is 2

@LCaiJie
Copy link
Contributor Author

LCaiJie commented Sep 12, 2024

yes @LCaiJie please do a PR to NuttX. The commit would be , Once it is merged. Then do a PR here with mtd:ramtron MB85RS256B address length is 2``[BACKPORT] mtd:ramtron MB85RS256B address length is 2

apache/nuttx#13380

@davids5
Copy link
Member

davids5 commented Sep 12, 2024

@LCaiJie Please force push with the commit message reading [BACKPORT] mtd:ramtron MB85RS256B address length is 2

@LCaiJie
Copy link
Contributor Author

LCaiJie commented Sep 13, 2024

@LCaiJie Please force push with the commit message reading [BACKPORT] mtd:ramtron MB85RS256B address length is 2

OK

@LCaiJie LCaiJie force-pushed the px4_firmware_nuttx-10.3.0+-ramtron branch from e0eca4c to b67312a Compare September 13, 2024 05:51
@davids5 davids5 merged commit 8ae3f06 into PX4:px4_firmware_nuttx-10.3.0+ Sep 13, 2024
@davids5
Copy link
Member

davids5 commented Sep 13, 2024

@LCaiJie Please do a PR in PX4 that re-points nuttx to px4_firmware_nuttx-10.3.0+ with this change merged.

@LCaiJie LCaiJie deleted the px4_firmware_nuttx-10.3.0+-ramtron branch September 19, 2024 02:31
@LCaiJie
Copy link
Contributor Author

LCaiJie commented Sep 19, 2024

@LCaiJie Please do a PR in PX4 that re-points nuttx to px4_firmware_nuttx-10.3.0+ with this change merged.

OK

@LCaiJie LCaiJie mentioned this pull request Sep 19, 2024
Merged
@LCaiJie
Copy link
Contributor Author

LCaiJie commented Sep 19, 2024

@davids5
PX4/PX4-Autopilot#23694

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@davids5 davids5 davids5 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LCaiJie @dagar @davids5