Skip to content

Conversation

@jfbblue0922
Copy link
Contributor

Summary
・In order to compile PX4-Autopilot with stm32h755II, I modified it to enable CONFIG_STM32H7_STM32H7X5XX.
・Added 'ARMV7M_HAVE_XXX' to the definition of STM32H7_STM32H7X5XX in the Kconfig file.

Impact
Use the CONFIG_STM32H7_STM32H7X5XX define.

Testing
We have confirmed that the firmware works correctly on PX4.

@davids5
Copy link
Member

davids5 commented Aug 1, 2024

@jfbblue0922 is this already in upstream NuttX?

@jfbblue0922
Copy link
Contributor Author

@davids5

This already in upstream NuttX.

  • Upstream already provides the compile switch CONFIG_STM32H7_STM32H7X5XX to configure the stm32h7x5.
  • Upstream provides ARCH_CHIP_STM32H7_CORTEXM7 to select core of the STM32H7x5.

For this reason, I think upstream PR is not necessary.
Thank you.

@davids5
Copy link
Member

davids5 commented Aug 6, 2024

@davids5

This already in upstream NuttX.

  • Upstream already provides the compile switch CONFIG_STM32H7_STM32H7X5XX to configure the stm32h7x5.
  • Upstream provides ARCH_CHIP_STM32H7_CORTEXM7 to select core of the STM32H7x5.

For this reason, I think upstream PR is not necessary. Thank you.

Then this is a partial Backport. Please change the commit message to say [BACKPORT] stm32h7: STM32H7X5XX selects hardware files

Copy link
Member

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then this is a partial Backport. Please change the commit message to say [BACKPORT] stm32h7: STM32H7X5XX selects hardware files

@jfbblue0922
Copy link
Contributor Author

@davids5

I changed the commit message.

@davids5
Copy link
Member

davids5 commented Aug 8, 2024

@jfbblue0922 We need to build test this:

Please create a PR in PX4 that updates the platforms/nuttx/NuttX/nuttx to this commit.

Use `NuttX with stm32h7: STM32H7X5XX backport' as the commit message.

@davids5
Copy link
Member

davids5 commented Aug 15, 2024

@jfbblue0922 Did you create the PX4 PR?

@davids5
Copy link
Member

davids5 commented Aug 16, 2024

@jfbblue0922 Please rebase this on the current px4_firmware_nuttx-10.3.0+ and create the PX4 PR to bring it in.

@jfbblue0922
Copy link
Contributor Author

@davids5
I rebased this PR on the current px4_firmware_nuttx-10.3.0+.
Then should I make a PR at https://github.com/PX4/PX4-Autopilot ?

@davids5
Copy link
Member

davids5 commented Aug 19, 2024

@davids5 I rebased this PR on the current px4_firmware_nuttx-10.3.0+. Then should I make a PR at https://github.com/PX4/PX4-Autopilot ?

Yes. It points PX4 auto pilot to the nuttx changes you made for testing.

git fetch  < px4 remote >
git checkout main
git submodule sync --recursive && git submodule update --init --recursive
git checkout -b pr-stm32h7-update
cd platforms/nuttx/NuttX/nuttx/
git checkout < your nuutx branch >
cd ../../../../
git commit platforms/nuttx/NuttX/nuttx/ -m"Nuttx with stm32h7: STM32H7X5XX selects hardware files backport"
git push -f < your remote for PX4> pr-stm32h7-update

Then open a PX4 PR.

@jfbblue0922
Copy link
Contributor Author

@davids5
I would like to do a git checkout < your nuutx branch >
but I get the error: pathspec 'pr-stm32h755II-2' did not match any file(s) known to git.
How do I checkout the 'pr-stm32h755II-2' branch?

@jfbblue0922
Copy link
Contributor Author

@davids5
I made a PX4 PR.
Thank you.

@davids5 davids5 merged commit d140f96 into PX4:px4_firmware_nuttx-10.3.0+ Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants