Skip to content

Conversation

@oleibman
Copy link
Collaborator

Fix #1425 which went stale 5 years ago, and which I've reopened. Style was not being set properly for last row. Also, Style was not being set at all for insertNewColumnBefore('B').

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Fix PHPOffice#1425 which went stale 5 years ago, and which I've reopened. Style was not being set properly for last row. Also, Style was not being set at all for insertNewColumnBefore('B').
@oleibman
Copy link
Collaborator Author

There's clearly a problem with Scrutinizer. Don't care.

@oleibman oleibman enabled auto-merge May 18, 2025 19:40
@oleibman oleibman added this pull request to the merge queue May 18, 2025
Merged via the queue into PHPOffice:master with commit 85a9a39 May 18, 2025
13 of 14 checks passed
@oleibman oleibman deleted the issue1425 branch May 18, 2025 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

Possible bug in ReferenceHelper::InsertNewBefore

1 participant