Skip to content

Conversation

@oleibman
Copy link
Collaborator

@oleibman oleibman commented Mar 8, 2025

Make things more maintainable (I hope).

This is:

  • a bugfix
  • a new feature
  • refactoring
  • additional unit tests

Checklist:

  • Changes are covered by unit tests
    • Changes are covered by existing unit tests
    • New unit tests have been added
  • Code style is respected
  • Commit message explains why the change is made (see https://github.com/erlang/otp/wiki/Writing-good-commit-messages)
  • CHANGELOG.md contains a short summary of the change and a link to the pull request if applicable
  • Documentation is updated as necessary

Make things more maintainable (I hope).
@oleibman
Copy link
Collaborator Author

oleibman commented Mar 8, 2025

No surprise at all about Scrutinizer complexity warning. Unconcerned.

@oleibman oleibman enabled auto-merge March 12, 2025 07:35
@oleibman oleibman added this pull request to the merge queue Mar 12, 2025
Merged via the queue into PHPOffice:master with commit b1beafb Mar 12, 2025
13 of 14 checks passed
@oleibman oleibman deleted the localesplit2 branch March 12, 2025 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant