Date::excelToDateTimeObject fatal error

[dirk39]

This is:

- [ X ] a bug report
- [ ] a feature request
- [ ] **not** a usage question (ask them on https://stackoverflow.com/questions/tagged/phpspreadsheet or https://gitter.im/PHPOffice/PhpSpreadsheet)

What is the expected behavior?

When I pass as first parameter excelTimestamp a value different from int or float I expect an InvalidArgumentException

What is the current behavior?

Method try to extract the number of days from wrong value provided and use it in $baseDate->modify($interval)->setTime($hours, $minutes, $seconds); but modify return false and concatenate method call raise a fatal error.

What are the steps to reproduce?

Please provide a Minimal, Complete, and Verifiable example of code that exhibits the issue without relying on an external Excel file or a web server:

<?php

require __DIR__ . '/vendor/autoload.php';

// Create new Spreadsheet object
$spreadsheet = new \PhpOffice\PhpSpreadsheet\Spreadsheet();

// add code that show the issue here...
$worksheet = $spreadSheet->createSheet();
$worksheet->setCellValueByColumnAndRow('A', 1, '5e8630b8-603c-43fe-b038-6154a3f893ab');
$cell = $worksheet->getCell('A1');
$cell->setValue('5e8630b8-603c-43fe-b038-6154a3f893ab');
$cell->getStyle()
  ->getNumberFormat()->setFormatCode('m/d/yyyy');

if(\PhpOffice\PhpSpreadsheet\Shared\Date::isDateTime($cell)) {
    $datetime = \PhpOffice\PhpSpreadsheet\Shared\Date::excelToDateTimeObject($cell->getValue());
}

Which versions of PhpSpreadsheet and PHP are affected?

1.6.0

[MarkBaker]

Basically the same as Issue 916.

PHPSpreadsheet doesn't try to prevent people creating a situation that is illogical, a uuid simply shouldn't be formatted as a date, because it isn't a date; and there is a certain expectation that people will use the library in a reasonably sensible matter. Preventing this would add overhead to the code, but as 2 issues have been raised on exactly the same topic in the space of 24 hours, it seems that people do want me to add that extra overhead.

[dirk39]

Hi @MarkBaker , I would never open the issue if method excelToDateTimeObject raise any kind of exception, but in my case it raises a fatal error. If is not a problem for you i can provide the PR that fix the problem.

Cheers

[MarkBaker]

I can fix it, that isn't the issue. It's simply adding an overhead for something that generally speaking shouldn't occur.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
If this is still an issue for you, please try to help by debugging it further and sharing your results.
Thank you for your contributions.

[oleibman]

Reopening. This was already resolved long ago by adding a numeric check in isDateTime, but there are some edge conditions which will be fixed shortly.