Skip to content

Add support for general requests from execution to consensus layer #2571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 7, 2025

Conversation

sparrowDom
Copy link
Member

@sparrowDom sparrowDom commented Jul 4, 2025

  • replaces the Execution layer contracts that are responsible for issuing EL -> CL communication
  • adds support to verify amounts these contracts are called with
  • the enableExecutionLayerGeneralPurposeRequests can be removed and the requests will still succeed. Though the tests won't be able to verify the values
  • the original problem why tests were failing is that mock contracts (e.g. MockBeaconConsolidation didn't have 1 wei of ETH to pay for the fee)
  • fixed the consolidation tests and added support for partial withdrawal tests

Copy link

github-actions bot commented Jul 4, 2025

Warnings
⚠️ 👀 This PR needs at least 2 reviewers

Generated by 🚫 dangerJS against 017593c

Copy link

codecov bot commented Jul 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (nicka/pectra@3c61180). Learn more about missing BASE report.

Additional details and impacted files
@@               Coverage Diff               @@
##             nicka/pectra    #2571   +/-   ##
===============================================
  Coverage                ?   40.54%           
===============================================
  Files                   ?      120           
  Lines                   ?     5643           
  Branches                ?     1493           
===============================================
  Hits                    ?     2288           
  Misses                  ?     3352           
  Partials                ?        3           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Avoided shadow fee on GeneralPurposeToConsensusLayerRequest
Copy link
Collaborator

@naddison36 naddison36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very good. Thanks

@naddison36 naddison36 merged commit e29a2e9 into nicka/pectra Jul 7, 2025
12 of 16 checks passed
@naddison36 naddison36 deleted the sparrowDom/pectraPartialWithdrawal branch July 7, 2025 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants