Sharded meta client and sharded aura fixes #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Have the AuraMetricsHttpFactory use the HttpV3SourceFactory directly. Add a static host config to the AuraMetricsHttpFactory
mailravi3390
changed the title
smrutilal2
reviewed
Oct 29, 2021
| @Override | ||
| public Iterator<MergedMetaTimeSeriesQueryResult> getTimeseriesAllShards(String namespace, String query) throws MetaFetchException { | ||
|
|
||
| final List<ShardEndPoint> shardEndPoints = setUpEndpoints(namespace); |
Contributor
There was a problem hiding this comment.
This is expensive to do for each call.
Contributor
There was a problem hiding this comment.
Ideally, it should be event driven. May be it's okay to start and we can revisit this. Needs a TODO in that case.
smrutilal2
reviewed
Oct 29, 2021
|
|
||
| for(int i = 0 ; i < futures.size(); i++) { | ||
| try { | ||
| timeSeriesQueryResults.add(futures.get(i).get()); |
Contributor
There was a problem hiding this comment.
Let's have a timeout in the future.get()
smrutilal2
reviewed
Oct 29, 2021
|
|
||
| final ShardEndPoint shardEndPoint = setUpEndpoints(namespace).get(shardId); | ||
| try { | ||
| return getResult(clients.get(shardEndPoint), query).get(); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.