Add DEFINE_SL_SAFE_STUB support #2
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for safe stubs using the DEFINE_SL_SAFE_STUB macros to improve resilience when symbols cannot be resolved at runtime. Key changes include updating the tests to utilize these macros, adding safe stub definitions in the C source, and updating the header files and documentation accordingly.
- Added safe stub declarations in Swift tests for unknown symbols.
- Introduced new safe stub macros in the header to handle symbol resolution failures gracefully.
- Updated documentation in README to reflect the safe stub usage and limitations.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Tests/SymbolLocatorTests/SymbolLocatorTests.swift | Updated test cases to use new safe stub functions. |
| Sources/SymbolLocatorTestsSupport/SymbolLocatorTestsSupport.c | Added safe stub definitions for unknown symbols. |
| Sources/SymbolLocator/include/SymbolLocator.h | Introduced safe stub macros and removed obsolete architecture-specific macro. |
| Sources/SymbolLocator/SymbolLocatorLog.m | Added logging implementation to support error reporting. |
| README.md | Updated documentation to include safe stub usage details. |
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for safe stubs that log errors at runtime when a symbol cannot be resolved, along with test and documentation updates.
- Added safe stub macro definitions in SymbolLocator.h for both SLF and SLPF variants.
- Updated the C support file to define safe stubs for unknown symbols.
- Introduced tests and expanded README documentation to explain safe stub usage and its limitations.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| Tests/SymbolLocatorTests/SymbolLocatorTests.swift | Added tests for safe stub usage and handling of unresolved symbols. |
| Sources/SymbolLocatorTestsSupport/SymbolLocatorTestsSupport.c | Introduced DEFINE_SL_SAFE_STUB_SLF definitions for unknown symbol functions. |
| Sources/SymbolLocator/include/SymbolLocatorLog.h | Provided logging functions for symbol resolution errors. |
| Sources/SymbolLocator/include/SymbolLocator.h | Added safe stub macro definitions along with architecture-specific assembly macros. |
| Sources/SymbolLocator/SymbolLocatorLog.m | Implemented logging functionalities for symbol location errors. |
| README.md | Updated documentation to detail safe stub behavior and limitations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.